From 7e9a5d351fe4cff7da69d8417a210d4acbdf7cb0 Mon Sep 17 00:00:00 2001 From: Daniela Plascencia Date: Wed, 18 Dec 2024 00:43:02 +0100 Subject: [PATCH 1/2] ci: use get_charms_build_with_cache.yaml workflow This workflow enables the usage of canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml for this CI, meaning that the integration tests and publish jobs are now able to download charm artefacts and use them consistently throught the various operations of this CI. Fixes #641 --- .github/workflows/on_pull_request.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 3d7eef10..9b32fbfd 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -3,19 +3,24 @@ name: On Pull Request # On pull_request, we: # * always publish to charmhub at latest/edge/branchname # * always run tests - +# * always run builds with cache on: pull_request: jobs: + get-paths-and-build: + name: Get charm paths and build with cache + uses: canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml@KF-6690-build-with-cache tests: name: Run Tests + needs: [get-paths-and-build] uses: ./.github/workflows/integrate.yaml secrets: inherit # publish runs in parallel with tests, as we always publish in this situation publish-charm: name: Publish Charm + needs: [get-paths-and-build] uses: ./.github/workflows/publish.yaml secrets: inherit From 27b6e7f733a5763fec6454ee9e6a468f33335f4c Mon Sep 17 00:00:00 2001 From: Daniela Plascencia Date: Thu, 19 Dec 2024 13:31:43 +0100 Subject: [PATCH 2/2] skip: pin main --- .github/workflows/on_pull_request.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 9b32fbfd..9bcc2213 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -10,7 +10,7 @@ on: jobs: get-paths-and-build: name: Get charm paths and build with cache - uses: canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml@KF-6690-build-with-cache + uses: canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml@main tests: name: Run Tests