Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom prop for stack form input column widths #800

Open
steverydz opened this issue Jul 5, 2022 · 2 comments
Open

Allow a custom prop for stack form input column widths #800

steverydz opened this issue Jul 5, 2022 · 2 comments
Labels
Feature 🎁 New feature or request P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system

Comments

@steverydz
Copy link
Contributor

The column width for labels in the Input component in a stacked form is 4. On Snapcraft listing forms we use a column width of 2 meaning this component won't work for our layout. It would be good if there were custom props to allow changing the default.

@bartaz bartaz added the Feature 🎁 New feature or request label Jul 6, 2022
@bartaz
Copy link
Member

bartaz commented Jul 6, 2022

Sounds like a reasonable request. Although we would need to do it for Input and Fields components (as one wraps around another), and there probably needs to be 2 props (one for label and one for input widths). So I'm not sure how complicated it will end up.

@bartaz
Copy link
Member

bartaz commented Sep 30, 2024

Triage: this seems relatively high effort and low impact. In new architecture we should revisit how forms are built.

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 🎁 New feature or request P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system
Projects
None yet
Development

No branches or pull requests

2 participants