Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip width hard to change #978

Open
vladimir-cucu opened this issue Sep 15, 2023 · 4 comments
Open

Tooltip width hard to change #978

vladimir-cucu opened this issue Sep 15, 2023 · 4 comments
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system

Comments

@vladimir-cucu
Copy link
Contributor

Issue

There are instances where we would like to limit the max-width of Tooltip without setting a fixed width for it (e.g. the generated content is dynamic and can be long). Unfortunately, something simple like max-width: 20rem; white-space: pre-wrap; won't work, as, in the case the width of the Tooltip is 0, the text would just appear one word per line (as seen in the attached screenshot).

Possible fix

We could utilize something similar to breakLines from maas-ui and break long text into lines of specific length, which would allow us to indirectly set-up max-width of Tooltip.

Screenshot

Screenshot from 2023-09-15 23-14-07

@bartaz
Copy link
Member

bartaz commented Sep 30, 2024

Triage: fixing tooltips in systematic way may be a hard issue, as they were not really designed to be handling a lot of formatted content and are hard to control from CSS side. This can be revisited and addressed in new architecture.

@bartaz
Copy link
Member

bartaz commented Sep 30, 2024

@vladimir-cucu Do you think this issue is pressing enough that it should be addressed in current React components as well?

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system labels Sep 30, 2024
@vladimir-cucu
Copy link
Contributor Author

@vladimir-cucu Do you think this issue is pressing enough that it should be addressed in current React components as well?

@bartaz Considering that the tooltips are not really designed to be handling a lot of formatted content and that this issue wasn't brought up in other projects, I would say it isn't pressing enough to be addressed in current React components, but it might be nice if it can be discussed about or addressed in the new architecture.

@huwshimi What is your opinion on this?

As a side note, here is the part that renders the tooltip from the attached screenshot and here is the CSS fix implemented in Juju Dashboard.

@huwshimi
Copy link
Collaborator

huwshimi commented Oct 3, 2024

@huwshimi What is your opinion on this?

I think this keeps coming up as an issue in various projects, but doesn't necessarily need to be solved by the current tooltip. Maybe we need a new multi-line tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system
Projects
None yet
Development

No branches or pull requests

3 participants