From 6ce8e13a8b74d71936536484461e26189f098c2e Mon Sep 17 00:00:00 2001 From: Jarred Wilson Date: Fri, 1 Mar 2024 16:53:00 -0500 Subject: [PATCH] Fix parts snippet tests --- tests/unit/extensions/test_qt_framework.py | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/unit/extensions/test_qt_framework.py b/tests/unit/extensions/test_qt_framework.py index 7dde10c8332..f44040598ba 100644 --- a/tests/unit/extensions/test_qt_framework.py +++ b/tests/unit/extensions/test_qt_framework.py @@ -249,22 +249,27 @@ def test_get_part_snippet(qt_framework_extension): @pytest.mark.parametrize(fixture_variables, base_values) -def test_get_parts_snippet(qt_framework_extension, name): +def test_get_parts_snippet_without_external_sdk(qt_framework_extension, name): + assert qt_framework_extension.get_parts_snippet() == {} + + +@pytest.mark.parametrize(fixture_variables, builtin_stable_values) +def test_get_parts_snippet_with_external_sdk(qt_framework_extension, name): sdk_snap = qt_framework_extension.qt_snaps.sdk["snap"] sdk_channel = qt_framework_extension.qt_snaps.sdk["channel"] assert qt_framework_extension.get_parts_snippet() == { - f"{name}/sdk": {"plugin": "nil", "stage-snaps": [f"{sdk_snap}/{sdk_channel}"]} + f"{name}/sdk": {"plugin": "nil", "build-snaps": [f"{sdk_snap}/{sdk_channel}"]} } -@pytest.mark.parametrize(fixture_variables, builtin_stable_values) -def test_get_parts_snippet_with_external_sdk(qt_framework_extension, name): - assert qt_framework_extension.get_parts_snippet() == {} - - @pytest.mark.parametrize(fixture_variables, builtin_edge_values) def test_get_parts_snippet_with_external_sdk_different_channel( qt_framework_extension, name ): - assert qt_framework_extension.get_parts_snippet() == {} + sdk_snap = qt_framework_extension.qt_snaps.sdk["snap"] + sdk_channel = qt_framework_extension.qt_snaps.sdk["channel"] + + assert qt_framework_extension.get_parts_snippet() == { + f"{name}/sdk": {"plugin": "nil", "build-snaps": [f"{sdk_snap}/{sdk_channel}"]} + }