Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate Firebase Dynamic Links / Remove Unnecessary actionCodeSettings #831

Open
3 of 13 tasks
kitayoshi opened this issue Feb 23, 2025 · 3 comments
Open
3 of 13 tasks

Comments

@kitayoshi
Copy link
Contributor

kitayoshi commented Feb 23, 2025

Plugin(s)

  • Analytics
  • App
  • App Check
  • Authentication
  • Crashlytics
  • Cloud Firestore
  • Cloud Functions
  • Cloud Messaging
  • Cloud Storage
  • Performance
  • Remote Config

Current problem

First of all, thank you for your great effort!

I am integrating verifyBeforeUpdateEmail() where I found that actionCodeSettings is needed. I don't need the dynamic link feature that to be opened in the application, so I just filled in the url and set handleCodeInApp: false.

However, I still get the DYNAMIC_LINK_NOT_ACTIVATED: FDL domain is not configured error.

Image

After searching, I found that the Firebase Dynamic Links feature is deprecated and the native SDK provides new interface support without dynamic links, specifically for email verification and similar use cases.

Reference: https://firebase.google.com/docs/auth/ios/email-link-migration

Preferred solution

  • Maybe make actionCodeSettings optional like sendEmailVerification() since it may not be necessary before dynamic links are deprecated.
  • Upgrade Firebase native SDK for iOS to 11.8.0+

Alternative options

No response

Additional context

No response

Before submitting

@robingenz
Copy link
Member

Feel free to create a PR for this. Just make sure that it's not breaking change.

@kitayoshi
Copy link
Contributor Author

@robingenz Sorry I am not familiar with the native part, so I am afraid of working on that.

But from my point of view, the easier solution is to make the actionCodeSettings parameter optional. Only two methods, sendSignInLinkToEmail() and verifyBeforeUpdateEmail(), mark it as required, which I think is not needed. I will dig into it a little.

@kitayoshi
Copy link
Contributor Author

@robingenz I have created a PR #832 making the actionCodeSettings optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants