Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(photo-editor): add annotatePhoto method #240

Open
3 of 20 tasks
walweh opened this issue Jul 29, 2024 · 1 comment
Open
3 of 20 tasks

feat(photo-editor): add annotatePhoto method #240

walweh opened this issue Jul 29, 2024 · 1 comment
Labels

Comments

@walweh
Copy link
Contributor

walweh commented Jul 29, 2024

Plugin(s)

  • Android Foreground Service
  • Android Battery Optimization
  • App Update
  • Background Task
  • Badge
  • Bluetooth Low Energy
  • Cloudinary
  • Datetime Picker
  • File Compressor
  • File Opener
  • File Picker
  • Live Update
  • Managed Configurations
  • NFC
  • Photo Editor
  • Printer
  • Screen Orientation
  • Zip

Current problem

The current implementation of the Capawesome/Capacitor Photo Editor does not support photo editing on iOS. While the Android version opens a photo editor app, the iOS version lacks this functionality. This feature request aims to address this disparity by integrating QLPreviewController to provide basic markup capabilities.

Preferred solution

Integrate Apple's QLPreviewController for iOS to allow users to view and mark up images. While this solution does not provide a full-fledged photo editor, it enables users to make annotations, drawings, and other markups directly on the images.

Benefits:

  • Consistency Across Platforms: Provides a more consistent user experience between Android and iOS.

  • User Convenience: Allows users to annotate and mark up images directly within the app, enhancing the app’s utility.

  • Leverage Native Capabilities: Utilizes Apple's native QLPreviewController to offer a seamless and integrated experience without the need for third-party libraries.

Alternative options

No response

Additional context

QLPreviewController

Before submitting

@robingenz
Copy link
Member

The editPhoto(...) method is aimed more at classic photo editing. But I can imagine that we add an annotatePhoto(...) method that implements this functionality. Feel free to submit a PR.

@robingenz robingenz changed the title feat: capcitor photo editor (ios extension) - Integrate QLPreviewController for Markup Support on iOS feat(photo-editor): add annotatePhoto method Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants