Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely replace pkg_resources with importlib.resources #311

Merged

Conversation

mattmess1221
Copy link
Contributor

Description

Resolves #307

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

All tests in pytest succeed

Checklist:

  • My code follows the style guidelines of this project (no GitHub actions complaints! run make lint before
    committing!)
  • I have commented my code, pydocstyle and darglint are happy, docstrings are in google docstring format, and all
    docstrings include a summary, args, returns and raises fields (even if N/A)
  • I have added tests that prove my fix is effective or that my feature works, if adding "functional" tests please
    note if there are any considerations for the vrnetlab setup
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bbb145a) 90.51% compared to head (84cf0da) 90.50%.

Files Patch % Lines
scrapli/helper.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   90.51%   90.50%   -0.01%     
==========================================
  Files          60       60              
  Lines        3488     3487       -1     
==========================================
- Hits         3157     3156       -1     
  Misses        331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlmontanari
Copy link
Owner

🔥 boom! thank you very much @killjoy1221 -- will merge when darlint ci is done (its slooooow, don't think this pr would have any issue there but ya know... just due diligence :))

@carlmontanari carlmontanari merged commit e02100d into carlmontanari:main Jan 11, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12: ModuleNotFoundError Upon Import
2 participants