Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database DSN should be more securely generated/assembled #31

Open
gtherond opened this issue Dec 27, 2024 · 3 comments
Open

Database DSN should be more securely generated/assembled #31

gtherond opened this issue Dec 27, 2024 · 3 comments

Comments

@gtherond
Copy link
Contributor

Hi team,

Currently, when setting a new casdoor instance using the helm-chart, we need to get the database credentials in plain text in order for the DSN on the configmap to be created from it.

That is kind of a burden as it let you get plaintext password on your values.yaml file.

Would it be doable to rather use kubernetes secrets already existing or generate it?

I'd like to be able to get something like this as an additional option:

database:
  secret:
    name: <string>
    generate: <bool>

As it needs a bit of additional works on the current helm chart so, I can work on it if you want.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 27, 2024

@gtherond sounds good. Plz make a PR. Need to keep compatible with the old mode

@gtherond
Copy link
Contributor Author

Sounds good to me!

@gtherond
Copy link
Contributor Author

gtherond commented Jan 7, 2025

I've got something quite nice, although I'm having a bug with the DSN and a specific condition to test, but it's not abandoned :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants