-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet/Mint] Implement update to NUT-08: Dynamic amount of tokens for change #183
Comments
I'd take this task in case no one else started yet. |
I think i should be
|
@BilligsterUser You mean like "the minimum number of blank outputs should be 1"? Yeah, that probably makes sense. |
Yes |
@callebtc Can you weigh in on this as well? Should we add the minimum to NUT-08? If yes, I could make it part of my PR cashubtc/nuts#17. |
Correct, thank you for noticing this @BilligsterUser! If fee reserve is set to 1 sat minimum, this would fail. I would write this as @xphade please feel free and go ahead with the fix of NUT-08 and also if you'd like to make appropriate changes to Nutshell! |
Instead of using 4 blank outputs, we should use the new dynamic amount. Relates to following NUT update: cashubtc/nuts@1676fe8 which uses
ceil(log2(fee_reserve))
.Todo:
The text was updated successfully, but these errors were encountered: