You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
katie-lamb opened this issue
Jan 18, 2024
· 0 comments
Labels
ferc1Anything having to do with FERC Form 1ppePlant Parts EIA (formerly the EIA plant parts list)testingWriting tests, creating test data, automating testing, etc.
As was pointed out in #3251 , currently test_validate_override_fixes is an integration test for the FERC to EIA entity matching module that tests the functionality of validate_override_fixes. The test has parameters with record IDs that need to be updated annually to ensure that those records are from report years that are processed in the fast ETL. The test uses the FERC to EIA training data within validate_override_fixes.
Instead, this test should be refactored to be a unit test that takes synthetic training data that is passed into validate_override_fixes. Additionally, instead of XFAIL-ing, the tests should pass if an expected exception is raised or failure condition is observed. Finally, validate_override_fixes shouldn't allow duplicate FERC IDs to be matched to different EIA records after the overrides are complete. There are test parameters set up to test this, but the validate_override_fixes function won't actually catch that condition in it's current state.
Refactor test_validate_override_fixes to be a unit test that uses synthetic FERC to EIA training data
Change XFAIL-ing tests to tests that pass if an expected exception is raised
Add a check in pudl.analysis.record_linkage.eia_ferc1_record_linkage.validate_override_fixes to make sure that there aren't duplicate FERC1 IDs matched to EIA records.
The text was updated successfully, but these errors were encountered:
zaneselvans
added
ferc1
Anything having to do with FERC Form 1
testing
Writing tests, creating test data, automating testing, etc.
ppe
Plant Parts EIA (formerly the EIA plant parts list)
labels
Jan 18, 2024
ferc1Anything having to do with FERC Form 1ppePlant Parts EIA (formerly the EIA plant parts list)testingWriting tests, creating test data, automating testing, etc.
As was pointed out in #3251 , currently
test_validate_override_fixes
is an integration test for the FERC to EIA entity matching module that tests the functionality ofvalidate_override_fixes
. The test has parameters with record IDs that need to be updated annually to ensure that those records are from report years that are processed in the fast ETL. The test uses the FERC to EIA training data withinvalidate_override_fixes
.Instead, this test should be refactored to be a unit test that takes synthetic training data that is passed into
validate_override_fixes
. Additionally, instead of XFAIL-ing, the tests should pass if an expected exception is raised or failure condition is observed. Finally,validate_override_fixes
shouldn't allow duplicate FERC IDs to be matched to different EIA records after the overrides are complete. There are test parameters set up to test this, but thevalidate_override_fixes
function won't actually catch that condition in it's current state.test_validate_override_fixes
to be a unit test that uses synthetic FERC to EIA training datapudl.analysis.record_linkage.eia_ferc1_record_linkage.validate_override_fixes
to make sure that there aren't duplicate FERC1 IDs matched to EIA records.The text was updated successfully, but these errors were encountered: