You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One thing in particular I'd like to have happen is to change the class names from flow_this or connector_this (since they become redundant after the change described in #422, to simply curl_step or webservice_step.
As a developer I find it much easier to jump to the class based on how it's labelled normally. Any grouping / categorisation and file location is not the point here, and that can be done separately.
Note that the suffix isn't required but I do think it will reduce the amount of results that might show up when fzf-ing files in your IDE. Also the reason I didn't opt for step_curl and step_webservice is because my IDE currently prefers things in order otherwise there is no match (which I admit is slightly annoying). For other things like triggers, they could be labelled cron_trigger.php or grouped under another folder.
If you need them to be grouped visually in your local file browser, I would question to what benefit would that serve? Could that benefit be pushed to something like the step chooser page instead?
Happy to hear other suggestions and critique for this approach.
The text was updated successfully, but these errors were encountered:
keevan
changed the title
Simplify step class names to "what they do" + "_step"
Simplify step class names to "what they do", e.g. curl, cron (trigger?)
Aug 8, 2022
One thing in particular I'd like to have happen is to change the class names from flow_this or connector_this (since they become redundant after the change described in #422, to simply curl_step or webservice_step.
As a developer I find it much easier to jump to the class based on how it's labelled normally. Any grouping / categorisation and file location is not the point here, and that can be done separately.
Note that the suffix isn't required but I do think it will reduce the amount of results that might show up when fzf-ing files in your IDE. Also the reason I didn't opt for step_curl and step_webservice is because my IDE currently prefers things in order otherwise there is no match (which I admit is slightly annoying). For other things like triggers, they could be labelled
cron_trigger.php
or grouped under another folder.If you need them to be grouped visually in your local file browser, I would question to what benefit would that serve? Could that benefit be pushed to something like the step chooser page instead?
Happy to hear other suggestions and critique for this approach.
The text was updated successfully, but these errors were encountered: