New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite an ugly list of constants in condition_base #101

Open

dmitriim opened this issue Jun 29, 2024 · 0 comments

Labels

bug enhancement

Member

dmitriim commented Jun 29, 2024 •

edited

Loading

A list of constants here https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/condition_base.php#L31 is ugly and shouldn't really belong to base class.

On top of that those operator values can get mixed up if used for conflicting type of fields. E.g. date and text types operators. Like here https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/condition_base.php#L31 or here https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/local/tool_dynamic_cohorts/condition/fields_trait.php#L65

This can lead to bugs and unexpected results.

dmitriim added bug enhancement labels

dmitriim changed the title ~~Rewrite ugly list of constants in condition_base~~ Rewrite an ugly list of constants in condition_base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment