Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that condition class is a child of condition_base class #105

Open
dmitriim opened this issue Aug 29, 2024 · 0 comments
Open

Check that condition class is a child of condition_base class #105

dmitriim opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@dmitriim
Copy link
Member

dmitriim commented Aug 29, 2024

Just realised that we never double checking that random condition classes are children of base condition class here https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/condition_manager.php#L42

@dmitriim dmitriim added bug Something isn't working enhancement New feature or request labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant