Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users with tool/dynamic_cohorts:manage access Manage rules page #76

Open
dmitriim opened this issue Apr 4, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@dmitriim
Copy link
Member

dmitriim commented Apr 4, 2024

The tool_dynamic_cohorts plugin ships with the tool/dynamic_cohorts:manage capability. For customer projects, I would love to be able to assign this capability to the manager role to allow managers / non-admins to configure the rules within the plugin.

Unfortunately, this does not work yet as on https://github.com/catalyst/moodle-tool_dynam ... ODLE_401_STABLE/index.php#L33, admin_externalpage_setup is used which limits the configuration page to admins only.

Can you extend the plugin in a way to allow all roles who have the tool/dynamic_cohorts:manage capability to configure the rules (in the GUI)?

@dmitriim dmitriim added the enhancement New feature or request label Apr 4, 2024
@dmitriim
Copy link
Member Author

dmitriim commented Apr 4, 2024

To be properly implemented, this all needs to be a new API bit when conditions can control who can apply them as some conditions expose stuff. Like list of courses, list of cohorts and etc.

We still can do a quick fix to convert index.php from config page to a normal page with tool/dynamic_cohorts:manage capability check. However this would only work for users who already have extended permissions for other part of Moodle.

danmarsden added a commit that referenced this issue Apr 4, 2024
issue #76: allow users with tool/dynamic_cohorts:manage access manage…
@dmitriim
Copy link
Member Author

The interim solution has been released. Still keen to do it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant