Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle lib needs updating to support PHP 8.0 and hgher. #222

Open
rikardow opened this issue Jul 9, 2024 · 1 comment
Open

Guzzle lib needs updating to support PHP 8.0 and hgher. #222

rikardow opened this issue Jul 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rikardow
Copy link

rikardow commented Jul 9, 2024

Hi, thanks for the great work on this plugin

We found some errors and deprecations in the codebase, here's the list

  1. File: admin/tool/trigger/guzzle/GuzzleHttp/Promise/functions.php
    Line: 222
    Message: Function each() is deprecated since PHP 7.2 and removed since PHP 8.0; Use a foreach loop or ArrayIterator instead
    Type: error

  2. File: admin/tool/trigger/guzzle/GuzzleHttp/Promise/functions.php
    Line: 257
    Message: Function each() is deprecated since PHP 7.2 and removed since PHP 8.0; Use a foreach loop or ArrayIterator instead
    Type: error

  3. File: admin/tool/trigger/guzzle/GuzzleHttp/Promise/functions.php
    Line: 313
    Message: Function each() is deprecated since PHP 7.2 and removed since PHP 8.0; Use a foreach loop or ArrayIterator instead
    Type: error

  4. File: admin/tool/trigger/edit.php
    Line: 74
    Message: Using ${var} in strings is deprecated since PHP 8.2, use {$var} instead. Found: ${pluginname}
    Type: warning

  5. File: admin/tool/trigger/edit.php
    Line: 74
    Message: Using ${var} in strings is deprecated since PHP 8.2, use {$var} instead. Found: ${eventname}
    Type: warning

Thank you very much for your efforts

@danmarsden
Copy link
Member

Hi there - thanks for your report! - if you have internal development capabilities, feel free to help further by submitting a PR to update the guzzle lib within the codebase. Also you might want to be aware that we have a newer plugin "tool_dataflows" which we're moving towards using for most of our clients over the older tool_trigger plugin (althogh there are also some php 8.2 deprecation notices that need to be fixed on that codebase too.)

@danmarsden danmarsden added the bug Something isn't working label Jul 9, 2024
@danmarsden danmarsden changed the title Errors and deprecations findings Guzzle lib needs updating to support PHP 8.0 and hgher. Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants