You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although, specific to the usage in frame_to_time, how badly do we want to mimic SpikeInterface and plan to eventually just have a single get_times function that either uses an underlying irregular time_vector or otherwise returns a np.arange scaled by the sampling frequency and shifted by an offset?
Right now we have
frames
on the functions for getting time:https://github.com/catalystneuro/roiextractors/blob/master/src/roiextractors/imagingextractor.py#L69
And
frame_idxs
in the function for getting the frames:roiextractors/src/roiextractors/imagingextractor.py
Lines 62 to 68 in b71f17d
But both of them are referring to the same. We should use either
frames
,frame_idxs
orframe_indices
for the two of them. Numpy usesindices
for their indexing routines so maybe that's a good choice:https://numpy.org/doc/stable/reference/arrays.indexing.html#routines-indexing
But I don't think it matters that much.
The text was updated successfully, but these errors were encountered: