Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rename this repo to drracket-catpuccin or any other suitable name #7

Open
PanAeon opened this issue Nov 20, 2024 · 6 comments
Open

Comments

@PanAeon
Copy link
Collaborator

PanAeon commented Nov 20, 2024

I've got a bug that when I install this package with raco / drracket it clashes with drracket itself, because pkg manager tries to infer the package name from repository name, and doesn't use info.rkt.

It could be a bug in package manager, but practically it's best to rename this repo to something else.

@sgoudham
Copy link
Contributor

Huh, I named it "catppuccin-theme" on the registry. Is the name not derived from there?

@sgoudham
Copy link
Contributor

Also this issue didn't exist before and the repository hasn't been renamed so I feel like that means it's a problem with the info.rkt file?

@PanAeon
Copy link
Collaborator Author

PanAeon commented Nov 21, 2024

well, the problem is not in the registry. When I use directory name or repository instead of racket registry then the system infers the name of the package as "drracket" from the directory/repo name which obviously clashes with drracket.
It's not the problem with the info.rkt file. At least to my knowledge. I will check)
No, it infers the package name from the directory name, and not from the name field from info.rkt. So it is best to rename the repository

Example for clarity:

cp -r drracket drracket2
# edit info.rkt, add field name "drracket-smth"
cd drracket2
raco pkg install  --auto $(pwd)
# installs package with a name `drracket2`
# same with a git repo url

I didn't caught the problem before because my fork is named "drracket-catpuccin"

@sgoudham
Copy link
Contributor

sgoudham commented Nov 26, 2024

I was able to run the command defined on the README

└ $ raco pkg install catppuccin-theme
Resolving "catppuccin-theme" via https://download.racket-lang.org/releases/8.15/catalog/
Resolving "catppuccin-theme" via https://pkgs.racket-lang.org
Downloading repository https://github.com/catppuccin/drracket.git#main commit 99a42c4f43fbd35ff1168219176e55393c0098af
raco setup: version: 8.15
raco setup: platform: aarch64-macosx [cs]
raco setup: target machine: tarm64osx
raco setup: installation name: 8.15
raco setup: variants: cs
raco setup: main collects: /opt/homebrew/Cellar/minimal-racket/8.15/share/racket/collects/
raco setup: collects paths:
raco setup:   /opt/homebrew/Cellar/minimal-racket/8.15/share/racket/collects/
raco setup: main pkgs: /opt/homebrew/opt/minimal-racket/share/racket/pkgs
raco setup: pkgs paths:
raco setup:   /opt/homebrew/opt/minimal-racket/share/racket/pkgs
raco setup:   /Users/goudham/Library/Racket/8.15/pkgs
raco setup: links files:
raco setup:   /opt/homebrew/opt/minimal-racket/share/racket/links.rktd
raco setup:   /Users/goudham/Library/Racket/8.15/links.rktd
raco setup: compiled-file roots:
raco setup:   same
raco setup:   /opt/homebrew/opt/minimal-racket/lib/racket/compiled
raco setup: main docs: /opt/homebrew/opt/minimal-racket/share/doc/racket
raco setup: --- updating info-domain tables ---                    [16:47:56]
raco setup: updating: /opt/homebrew/opt/minimal-racket/share/racket/info-cache.rktd
raco setup: --- pre-installing collections ---                     [16:47:56]
raco setup: --- installing foreign libraries ---                   [16:47:56]
raco setup: --- installing shared files ---                        [16:47:56]
raco setup: --- compiling collections ---                          [16:47:56]
raco setup: --- parallel build using 8 jobs ---                    [16:47:56]
raco setup: 7: idle
███████████████▊██████████████▊██████████████▊██████████████▊██████████████▊██████████████▊██████████████▊██████████████▊██████████████▊██████████████ 100%
raco setup: --- creating launchers ---                             [16:47:57]
raco setup: --- installing man pages ---                           [16:47:57]
raco setup: --- installing collections ---                         [16:47:57]
raco setup: --- post-installing collections ---                    [16:47:57]

Is the theme not available in the IDE after running that command? @PanAeon

I don't see why we need to rename the repository in order support downloading straight from the GitHub repository if it exists on the registry. Are you able to specify a different folder while cloning like in normal git - git clone [email protected]:catppuccin/drracket catppuccin-drracket ?

@PanAeon
Copy link
Collaborator Author

PanAeon commented Nov 26, 2024

Again, I'm not a racket expert, so it is my guess, but:
Your example works because raco fetches the metadata from the registry.
raco pkg install catppuccin-theme

But it is totally acceptable to use the following command:
raco pkg install https://github.com/catppuccin/drracket

now it is broken - it clashes with drracket. There're details in the issue I've linked. In two words it is a design flaw in the raco that it doesn't look into the name field of the info.rkt when installing packages from the github/local dir.

Well, we can close it as is, but I'd rather rename the repo in order to avoid unnecessary bug reports from the confused users (and I was one of them).

@PanAeon PanAeon changed the title Please rename this repo to drracket-catpuccin or anything Please rename this repo to drracket-catpuccin or any other suitable name Nov 26, 2024
@backwardspy
Copy link
Member

backwardspy commented Nov 27, 2024

@PanAeon there is a redirect from catppuccin/drracket-catppuccin to catppuccin/drracket, would you mind testing to see if it works?

raco pkg install https://github.com/catppuccin/drracket-catppuccin.git

if so we'll add it to the documentation. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants