Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session status is not fully highlighting after v2 update #464

Closed
2 tasks done
adaviloper opened this issue Jan 18, 2025 · 8 comments
Closed
2 tasks done

Session status is not fully highlighting after v2 update #464

adaviloper opened this issue Jan 18, 2025 · 8 comments
Labels
bug Something isn't working

Comments

@adaviloper
Copy link

I am not requesting help with my configuration and believe something is genuinely broken.

  • Something is really actually broken.

Is there an existing issue outlining your problem?

  • I have searched the existing issues and they do not solve my problem.

Describe your problem.

This seems to be related to #394 .

Paste your configuration.

set -g @catppuccin_session_text " #S"
set -g @catppuccin_session_color "#{@thm_green}"
set -g @catppuccin_status_session_text_bg "#{@thm_green}"
set -g @catppuccin_status_connect_separator 'no'
set -g @catppuccin_status_left_separator ''
set -g @catppuccin_status_middle_separator '|'
set -g @catppuccin_status_right_separator ''

Attach screenshots.

Before:
image

After:
image

What tmux version are you seeing the issue on?

tmux 3.5a

Any additional comments?

No response

@adaviloper adaviloper added the bug Something isn't working label Jan 18, 2025
@kjnsn
Copy link
Collaborator

kjnsn commented Jan 19, 2025

I'm not sure what the actual problem is. What are you expecting to happen?

@adaviloper
Copy link
Author

It's referenced in #394 where the session status module changes colors to red when the prefix key is triggered. You can see in the first screenshot that it used to modify the entire session module. After updating to the latest v2, it only updates the background color for the icon and the middle separator, but the session text and the right separator remains green.

I see that the icon style is configured here, but I don't know how to get the rest of the module to update without affecting the different modules in the repo.

@kjnsn
Copy link
Collaborator

kjnsn commented Jan 19, 2025

This is because you have set @catppuccin_status_session_text_bg. So it looks like this is working the way you have configured it to. Is that correct?

@adaviloper
Copy link
Author

It doesn't seem to be. When I remove that variable, it looks like this:

Image Image

@kjnsn
Copy link
Collaborator

kjnsn commented Jan 19, 2025

Did you completely restart tmux after the change?

@kjnsn
Copy link
Collaborator

kjnsn commented Jan 19, 2025

This is WAI though, only the icon/separator is meant to change color. You can configure the text to change color easily:

set -g @catppuccin_session_text "#[bg=#{?client_prefix,#{E:@thm_red},#{E:@thm_green}}] #S"

@kjnsn kjnsn closed this as completed Jan 19, 2025
@adaviloper
Copy link
Author

I did restart it completely. Is it working as intended? Prior to v2, you can see in the screenshot that the entire status module would update. Or is the intended part that the plugin is no longer scoped to support that functionality?

@adaviloper
Copy link
Author

Sorry for bothering so much and thanks for the help! That snippet gets me close, but how can I include the last bit of the right separator in that?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants