Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use span-based api when exporting metric infos #404

Open
lust4life opened this issue Mar 15, 2019 · 2 comments
Open

use span-based api when exporting metric infos #404

lust4life opened this issue Mar 15, 2019 · 2 comments

Comments

@lust4life
Copy link
Contributor

I'm not going to argue here at all, but we should consider using netcoreapp2.2 in the future, and defaulting to the non-allocating Span-based API:s.

Originally posted by @haf in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MjE0NjgzNzAx/pull_request_reviews/more_threads

@lust4life lust4life mentioned this issue Mar 15, 2019
4 tasks
@lust4life
Copy link
Contributor Author

seems right now, the span-based api in StringBuilder doesn't give more good here. since what we do is format data to string then append to stringbuilder, then generate bytes to suave's response content.

maybe these would help :

After these have been done and expose, I think we can make it easier to get the benefit. What do you think ?

@haf
Copy link
Member

haf commented Mar 22, 2019

I think that if we use the Span based API, I can replace the server from underneath to one that supports writing straight to the socket in the future.

I don't think we'll get much benefit immediately though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants