-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the Data Flow and Component Structure #64
Comments
Hi @akshay2905, I've seen a pull request has been merged for this issue. Is it complete. Can u bring some light into this. I'm interested to contribute ☺ |
Hey @VenkateshKatabathula Great to hear from you. The pull request I had generated was part of a series of iteration that would be required to redesign the structure. Each iteration would have one component redesigned to the new structure. The first one was done to showcase the basic structure of how the new components would be designed. I would recommend you to setup the project and explore it for a while. File bugs or possible enhancements you would like to recommend. I would add specific issues or feature request once a couple of iterations are completed, which should be hopefully the end of this week. Ping me if you face any issues in setting up the project. |
Thanks @akshay2905. I'll start contributing 😃 |
@akshay2905 just had a look at project. Just saw there were lot of lint and all. Update #1: even on the develop branch it's the same. I found that you have merged some changes to that branch and marked it as default. So I checked with that branch as well. No luck still. However, I use node 6 should that be a problem. I don't think so. Please let me know your views 👍 |
@VenkateshKatabathula I have updated the process, as the version 2.0 development was executed in a different scenario. Please use the current develop branch to update the new changes. Sharing the link of the current process which has been adopted after the first release - Branching Model. I am currently working on redesign-component-sidebar branch which has redesign-app as the parent branch. Thus all the redesign-[component-name] would be merged into redesign-app. Once the redesign is complete we would merge it into develop and then master for production. Yes there are linting issues, but they wont affect working of the project. Most of them are warnings, which we would need to look into. Sadly I wasnt able to find a design pattern or framework in which we can design our app into. Thus the redesigning is taking place. Most of the issues are related to that. The good thing about the React community is the release cycle. We can surely update the packages, but need to make sure that all the components are compatible with it. I did try to update it, but was facing compatibility issues with some of them. We would definitely look into it, once the redesign phase is complete. |
The app works fine, but there is lot of room improvement in the design of the app. Following are the major improvements that can be made with minimal efforts -
The text was updated successfully, but these errors were encountered: