Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase usernames #45

Open
alexwennerberg opened this issue Dec 31, 2023 · 2 comments
Open

Lowercase usernames #45

alexwennerberg opened this issue Dec 31, 2023 · 2 comments

Comments

@alexwennerberg
Copy link
Contributor

Right now Alex and alex are separate usernames. I think that the most clear approach is to force all names to lowercase. What do you think?

@cblgh
Copy link
Owner

cblgh commented Jan 6, 2024

i think a better solution would be to explore something like COLLATE NOCASE, or equivalent / better query, on user creation e.g. adapting checkUserExists or whatever the function is called

@alexwennerberg
Copy link
Contributor Author

I think that makes sense to me. right now, a username can be any unicode string of any length, I am thinking of adding some input validation. Here's what I'd add:

  • max length 20
  • min length 1
  • allow only ascii alphanumeric plus '_'

limiting to ascii may be an issue for i18n, but allowing for any string causes a number of problem on the web. what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants