-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into how to enable alt text syntax for images #80
Comments
oh dang, the differences in markdown renderers. it probably never worked in that case! |
note to self (written in my couch):we can use the markdown package’s ast modification to try to get the alt text and set it properly:https://github.com/gomarkdown/markdown/blob/master/examples/modify_ast.go while we are at it, we can move the lazy loading into the same gomarkdown-specific code and out of the server or database package where it currently residesmight also be good to upstream the bug report:https://github.com/gomarkdown/markdown/issues
|
Nice, yes, that looks promising. Thanks for looking into it. Issue upstreamed in the meantime: gomarkdown/markdown#318 |
Oh nice some source codez gomarkdown/markdown#318 (comment) |
@decentral1se just spun up my dev forum, and i'm having alt text displayed! but not can you give me the exact post input you are using so i can repro the issue you opened this with? here's what i used which works
and actually the drawtober thread is a good example of alt text being used and actually in the markup! https://forum.merveilles.town/thread/101/drawtober-2024-67/#1887 |
@decentral1se i'm now using the alt text to also set the |
oh sheeeyat, that's great stuff! ok lemme do a test on the forum / dev instance and hopefully we can close this one out 🙏 nice detective work & patch! |
If I do this in a post:
![my alt text](https://...)
I get:
<p><img loading="lazy" src="https://..."/></p>
The
alt="my alt text"
doesn't seem to make it through the conversion?The text was updated successfully, but these errors were encountered: