Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache upgrade request #21

Closed
godspeed20 opened this issue Mar 18, 2019 · 3 comments
Closed

Apache upgrade request #21

godspeed20 opened this issue Mar 18, 2019 · 3 comments

Comments

@godspeed20
Copy link

I might be wrong, but we're getting warnings in the logs of green yet relating to Apache responseprocesscookies , and it says the cookie has an invalid expires attribute. It looks like this might be due to the http client... Same can be seen here:
gradle/gradle#1596
https://issues.apache.org/jira/browse/HTTPCLIENT-1077

I can't tell which version is in use from the project file though (looks like it doesn't even use Apache somehow) but you please help take a quick look?

Thanks

@cburgmer
Copy link
Owner

Hey, sorry for the late answer.

greenyet indeeds ships with http-kit, not the Apache HttpClient. Please double check that you are not running a fork, similar to PR #19.

I've bumped all dependencies in the latest 2 commits. You might want to check whether that fixes anything. You can build the jar yourself by running

./lein ring uberjar

@godspeed20
Copy link
Author

Thanks Chris, hope you're well. I didn't notice that pr, let me double check, maybe that's the culprit after all

@godspeed20
Copy link
Author

Looks like we're using a fork so I'll dig that way, sorry about that. Hope you're well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants