Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError attempting to unregister handler #31

Open
jasonkarns opened this issue Dec 12, 2017 · 0 comments
Open

TypeError attempting to unregister handler #31

jasonkarns opened this issue Dec 12, 2017 · 0 comments

Comments

@jasonkarns
Copy link

.off does not guard against _handlers[gator.id][event] being undefined. Thus:

https://github.com/ccampbell/gator/blob/master/gator.js#L187 throws a TypeError exception when attempting to access the selector on undefined.

Uncaught TypeError: Cannot read property '<redacted selector>' of undefined
jasonkarns added a commit to jasonkarns/gator that referenced this issue Dec 12, 2017
@jasonkarns
Handle empty events array
8549851 
It's common to pre-emptively call `off` with an event and handler prior
to any handlers being registered. This is a safeguard to ensure that the
same handler isn't attached multiple times. In this scenario, the events
array isn't checked for existence prior to the accessor call (for the
given selector). Thus a TypeError is raised.

Closes ccampbell#31
@jasonkarns jasonkarns mentioned this issue Dec 12, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonkarns