Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "validation using joi object" assignment needs more hints #131

Closed
Pomax opened this issue Jan 13, 2015 · 4 comments
Closed

the "validation using joi object" assignment needs more hints #131

Pomax opened this issue Jan 13, 2015 · 4 comments

Comments

@Pomax
Copy link

Pomax commented Jan 13, 2015

Going from "the Joi validation isn't tested" in the "Validation" assignment to "good luck figuring out how to make Joi do the thing we're asking you" in the "Validation using Joi object" assignment is too big a leap.

Pointing to the docs does not help in this case, but is simply throwing the manual at the learner and expecting them to know what they're even looking for. It would be more helpful, and a better learning experience, if the hints give examples of how to do the things the assignment asks for, like how to require one value if another value is some specific value, or missing, and how to make validation pass, or fail, if more than the necessary arguments are found.

Right now, there is a blob of Joi validation that has zero meaning for the learner, without any text that explains why things like .options(), .with(), and .without() are shown, or what they do.

I can't find out how to do the first thing that's being asked, for instance. I've never used Joi before, and despite being proficient in Node, Express, model validation, etc. the Joi package is not presented as very joyful in these two assignments. Instead it's presented as a bloody hard thing that requires I read an entire manual to even understand. Which, even when I read it, doesn't seem to tell me how to do what the assignment makes feel is a rather basic thing.

That doesn't make me hapi =)

@Pomax Pomax changed the title the "validation with join" assignment needs more hints the "validation using joi object" assignment needs more hints Jan 13, 2015
@nvcexploder nvcexploder modified the milestone: 1.0.3 Jan 28, 2015
@nvcexploder
Copy link
Contributor

Checking this out in conjunction with #132

@nvcexploder
Copy link
Contributor

@Pomax check this out: https://github.com/nvcexploder/makemehapi/blob/joi/exercises/validation_using_joi_object/problem.md

Does that look like it's on the right path so far?

@Pomax
Copy link
Author

Pomax commented Jan 29, 2015

that's definitely the right path, yes!

@nvcexploder
Copy link
Contributor

Cool! I'll continue on it then. :)

On Jan 28, 2015, at 9:34 PM, Mike Kamermans [email protected] wrote:

that's definitely the right path, yes!


Reply to this email directly or view it on GitHub.

@fiveisprime fiveisprime removed this from the 1.0.3 milestone Aug 14, 2015
@Pomax Pomax closed this as completed Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants