Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #17

Open
cberys opened this issue Mar 15, 2021 · 5 comments
Open

Add logging #17

cberys opened this issue Mar 15, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@cberys
Copy link
Member

cberys commented Mar 15, 2021

Add logging specifically for changes made to files on read in, but I would guess also in general. Please edit or add to this issue.

@DocOtak
Copy link
Member

DocOtak commented Mar 15, 2021

Clarification, these are log messages e.g. to a terminal about what is going on internally?

@cberys
Copy link
Member Author

cberys commented Mar 15, 2021

I think yes for the use stated, but there might have been other uses as well. I have a note from the meeting to make this issue but I wasn't sure on the specifics.

@DocOtak DocOtak added this to the Fast Reader milestone Dec 11, 2021
@DocOtak
Copy link
Member

DocOtak commented Dec 11, 2021

Lots of debug logging in the fast reader branch so far, so this will definitely happen as I just need to leave them all in rather than remove. It's using the python logging module, so you need to attach a logging handler to it to get output if using the API directly.

@DocOtak DocOtak self-assigned this Dec 11, 2021
@DocOtak DocOtak added the enhancement New feature or request label Dec 11, 2021
@DocOtak DocOtak removed this from the Fast Reader milestone Oct 4, 2023
@DocOtak
Copy link
Member

DocOtak commented Aug 7, 2024

@cberys do you want more logging message in specific places?

@cberys
Copy link
Member Author

cberys commented Aug 12, 2024

@DocOtak I believe there has been a ton of improvement to error messages for the user since this issue was made.(I think in the beginning there was basically none or very limited) I don't know if you want to close the issue or leave it open for when specific requests come up and rename to "logging wish list" or whatever - up to you.

Additionally - maybe create some instructionals on using the logging module and what is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants