Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter distribution chart on the right #16

Closed
pkolano opened this issue Mar 22, 2022 · 3 comments
Closed

Letter distribution chart on the right #16

pkolano opened this issue Mar 22, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@pkolano
Copy link

pkolano commented Mar 22, 2022

Would be nice to have a letter distribution chart on the right. Don't know if it could be used given your changes to the code, but there was a pull request to the hanshuebner version that did this at hanshuebner#77. Thanks!

@cdot cdot added the enhancement New feature or request label Mar 22, 2022
@cdot
Copy link
Owner

cdot commented Mar 22, 2022

I looked at that PR but decided not to follow up on it because it uses so much screen real estate, and would give an unfair advantage to players on desktop and tablet devices versus those on mobiles (yeas, I have a couple of those!). However it would be easy enough to add, and could be useful for those learning to play at competition level where tracking the remaining letters in the bag becomes an issue. The PR as given would not work with the current code, but the principle would be simple enough to apply. I'd want it to be optionally enabled by the game creator, and optionally displayed under user settings control. I'd be happy to entertain a PR.

@cdot cdot added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Apr 15, 2022
@cdot
Copy link
Owner

cdot commented Sep 20, 2022

I just (mea culpa) noticed that the letter distribution chart is printed on scrabble boards. So the distribution chart should be showable, for scrabble boards at least. My inclination is to do it as a dialog, though.

@cdot
Copy link
Owner

cdot commented Sep 20, 2022

It's there in 2.1.2

@cdot cdot closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants