Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request - Migrade HwndHost code into main repository #4982

Closed
amaitland opened this issue Nov 16, 2024 · 1 comment · Fixed by #4981
Closed

Feature Request - Migrade HwndHost code into main repository #4982

amaitland opened this issue Nov 16, 2024 · 1 comment · Fixed by #4981
Assignees
@amaitland
Labels
wpf.hwndhost WPF HwndHost specific implementations
Milestone
132.3.x

Comments

@amaitland
Copy link
Member

Based on discussion in #4964 (comment)

This will move the HwndHost source out of it's own repository and into a HwndHost sub folder in the Wpf project.

This has a number of advantages, the HwndHost implementation is often left behind currently when something new is added/changed, so we can keep that in sync with minimal effort now.

Changing to how the package is published will be the thing.
@amaitland amaitland self-assigned this Nov 16, 2024
@amaitland amaitland mentioned this issue Nov 16, 2024
Merged
9 tasks
@amaitland amaitland linked a pull request Nov 16, 2024 that will close this issue
Import CefSharp.Wpf.HwndHost into main repository. #4981
Merged
9 tasks
@amaitland amaitland added this to the 132.3.x milestone Jan 17, 2025
@amaitland amaitland added wpf.hwndhost WPF HwndHost specific implementations and removed feature-request labels Jan 17, 2025
amaitland added a commit that referenced this issue Jan 17, 2025
@amaitland
Wpf.HwndHost - Fix nuget package creation errors
8f5fc82 
#4982
@amaitland
Copy link
Member Author

An example will be added to the MinimalExample.

cefsharp/CefSharp.MinimalExample#148

For now it will be just a modified version of the Wpf example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
wpf.hwndhost WPF HwndHost specific implementations
Projects
None yet
Milestone
132.3.x
Development

Successfully merging a pull request may close this issue.

Import CefSharp.Wpf.HwndHost into main repository. cefsharp/CefSharp
1 participant
@amaitland