basic_consume returns a tuple instead of a consumer_tag

[xordoquy]

Hi,

Since 2.4, I notice the call to basic_consume without consumer_tag nor nowait now returns a tuple with a consumer_tag instead of the consumer_tag itself as was the case in the previous release.
It is not clear to me whether it's intended or not.

[thedrow]

I believe it was intended.
#221

[xordoquy]

I saw that PR but fail to understand whether or not the change in the returned value was intended.
@matusvalo, any idea about ?

edit: I mean, the change in the returned value from basic_consume that is.

[matusvalo]

@thedrow @xordoquy unfortunately it was not intentional. I missed returning p :-(. There is no need of returning tuple. It is slightly pain with return values in py-amqp because they are often not documented. Of course the fix is easy... I can fix it and update unittests with proper tests if you like.

[thedrow]

Please do and I'll release a bug fix version.

[matusvalo]

Done. I have also added issue for improving API of basic_consume() - #241.

[pquentin]

@thedrow a bug fix release would be nice! We currently need this workaround in our code:

if isinstance(consumer_tag, tuple):
    consumer_tag = self.consumer_tag[0]

Thank you for your work on py-amqp!