New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base hasher for the row/col roots to sha2 #187

Closed

liamsi opened this issue Mar 8, 2021 · 2 comments

Labels

good first issue

Member

liamsi commented Mar 8, 2021 •

edited

Loading

Currently: https://github.com/lazyledger/lazyledger-core/blob/ad4ee87da2e449b4e88f9d334cc89c0a5d4094e6/types/consts.go#L35

In the spec though: https://github.com/lazyledger/lazyledger-specs/blob/master/specs/data_structures.md#hashing

Note that spec was preferring sha3 before.

liamsi added the good first issue label

Member Author

liamsi commented Mar 9, 2021 •

edited

Loading

My understanding is that this will already be tackled in #178

liamsi mentioned this issue

Use the IPFS core object to post block data during proposal #178

Merged

Member Author

liamsi commented Mar 17, 2021

This was resolved in #178

liamsi closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment