Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share: GetLeavesByNamespace should allow returning only proofs without data #1836

Closed
Tracked by #1835
Wondertan opened this issue Feb 28, 2023 · 0 comments · Fixed by #1870
Closed
Tracked by #1835

share: GetLeavesByNamespace should allow returning only proofs without data #1836

Wondertan opened this issue Feb 28, 2023 · 0 comments · Fixed by #1870
Assignees
@vgonkivs
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Feb 28, 2023 •
edited
Loading

Overview

The goal here is to extend the functionality of GetLeavesByNamespace to allow getting proofs only. It always gets data with proofs optionally, but we should enable it to get either data or Merkle proofs or both.

Motivation

This is required for Available method of BlobModuleAPI, which checks whether some data blob is included in the main chain.

Details

The suggested but optional way if achieve this is with functional options.
@Wondertan Wondertan mentioned this issue Feb 28, 2023
Closed
@Wondertan Wondertan added the area:shares Shares and samples label Feb 28, 2023
@Wondertan Wondertan changed the title share: GetSharesByNamespace should allow returning only proofs without data share: GetLeavesByNamespace should allow returning only proofs without data Feb 28, 2023
@Wondertan Wondertan mentioned this issue Feb 28, 2023
Open
@vgonkivs vgonkivs mentioned this issue Mar 7, 2023
Merged
5 tasks
@vgonkivs vgonkivs moved this from TODO to In Review in Celestia Node Mar 10, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Celestia Node Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgonkivs vgonkivs

Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactoring(share/ipld)!: rework getLeavesByNamespace vgonkivs/celestia-node
3 participants
@Wondertan @vgonkivs @renaynay