Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share: Extend Getter to enable requesting proofs and adjust all the implementations #1838

Closed
Tracked by #1835
Wondertan opened this issue Feb 28, 2023 · 2 comments
Closed
Tracked by #1835
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Feb 28, 2023

Overview

Current Getter's method GetSharesByNamespace always gets __data and proofs __ by namespace, and the goal is to extend the interface enabling getting only proofs without data.

Motivation

This is required for the Available method of #1835, which checks whether some data blob is included in the main chain.

Details

The recommended way to achieve the goal is to extend GetSharesByNamespace with options defined next to the interface and make each implementation handle them. An alternative could be to make separate GetProofsByNamespace

Refs

Depends on #1837

@distractedm1nd
Copy link
Collaborator

Do we really still want this?

@Wondertan
Copy link
Member Author

We have it already as a separate GetProof method. It's required for Rollkit

@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants