Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: SubmitPayForBlob should support multiple blobs #1840

Closed
Tracked by #1835
Wondertan opened this issue Feb 28, 2023 · 5 comments · Fixed by #1963
Closed
Tracked by #1835

state: SubmitPayForBlob should support multiple blobs #1840

Wondertan opened this issue Feb 28, 2023 · 5 comments · Fixed by #1963
Labels
area:state Related to fetching state and state execution

Comments

@Wondertan
Copy link
Member

Wondertan commented Feb 28, 2023

Overview

The current version of SubmitPayForBlob only supports sending only one data blob. At the same time, v0.12.0 of the app introduced the PFB version capable of sending multiple blobs per transaction, which includes them into the chain atomically. The goal is to extend SubmitPayForBlob to leverage the new PFB.

Motivation

This is required for the Submit method of #1835, which allows sending multiple Blobs per call. We could implement each blob as a separate transaction, but then we lose atomicity between their transaction inclusion.

Details

The recommended path is to extend the method to achieve the goal

@renaynay renaynay added area:state Related to fetching state and state execution and removed needs:triage labels Mar 2, 2023
@renaynay
Copy link
Member

renaynay commented Mar 2, 2023

@evan-forbes are there any plans to provide an endpoint in app for this ^ ?

@evan-forbes
Copy link
Member

we don't have any plans atm the use a different endpoint other than the standard one for tendermint that accepts arbitrary txs.

@Wondertan
Copy link
Member Author

We don't need any custom endpoints to implement this

@renaynay
Copy link
Member

renaynay commented Mar 6, 2023

so basically data field will be [][]byte ?

@Wondertan
Copy link
Member Author

We should also allow sending two blobs with different namespaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants