Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror the linting of the upstream sdk #22

Open
evan-forbes opened this issue Feb 25, 2021 · 0 comments
Open

Mirror the linting of the upstream sdk #22

evan-forbes opened this issue Feb 25, 2021 · 0 comments

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Feb 25, 2021

There were two nolint directives added in #19 that mute the linter. These should be removed, or kept, depending on what the upstream cosmos-sdk does about some utility functions that were removed in the tendermint master branch, but kept in the latest release

We have a few options, one of which should eventually become the clear solution, as this linting issue is a tad complex. It's unclear if the linter should or shouldn't be picking up the write permission error. There are many different permissions used, including a few 0777. They seem to be avoiding detection, as the linter misses fucntions that use the tmos package. Ultimately, we should probably do whatever the cosmos-sdk does. For now though, the nolint directive has been added for our own sanity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant