Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Balance method #8

Open
tzdybal opened this issue May 30, 2022 · 2 comments
Open

Implement Balance method #8

tzdybal opened this issue May 30, 2022 · 2 comments
Assignees
@Regis-Caelum
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tzdybal
Copy link
Member

tzdybal commented May 30, 2022

Balance method needs to be implemented.

Specs: https://docs.celestia.org/developers/node-api/#get-balance

Type returned by celestia-node (Coin from cosmos-sdk) is so small, that it can be simply created locally, without introducing dependency on cosmos-sdk.
@tzdybal tzdybal added enhancement New feature or request good first issue Good for newcomers labels May 30, 2022
@Regis-Caelum
Copy link

Hey @tzdybal, I would like to take this one.

@Regis-Caelum Regis-Caelum mentioned this issue May 31, 2022
Closed
@Regis-Caelum
Copy link

Hey, @tzdybal I implemented the proposed method, let me know of the changes in the PR, if any.

@adlerjohn adlerjohn linked a pull request Jun 1, 2022 that will close this issue
Implement Balance method and corresponding tests #12
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Regis-Caelum Regis-Caelum

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Execution Environments
Status: TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Balance method and corresponding tests Regis-Caelum/go-cnc
2 participants
@tzdybal @Regis-Caelum