Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: rework Subscription #27

Open
vgonkivs opened this issue Sep 7, 2023 · 0 comments
Open

service: rework Subscription #27

vgonkivs opened this issue Sep 7, 2023 · 0 comments

Comments

@vgonkivs
Copy link
Member

vgonkivs commented Sep 7, 2023

Our current Subscription method, which appears to allow users to subscribe to a specific proof type, is actually providing access to a particular pub-sub topic. This is not in line with our intended functionality, as pub-sub interactions should be restricted to internal usage only. To address this issue, I propose that we discontinue the option for users to interact with the pub-sub mechanism. Instead, we should offer a subscription to the datastore where proofs are stored. This subscription would return an iterator, enabling users to navigate between different proofs for a single proof type. Additionally, implementing this change would grant us the capability to enable subscriptions even before the service starts, a feature that is currently unavailable.

Moreover, this new approach would allow us to access proofs one by one, which is especially beneficial when dealing with a large number of proofs. It simplifies the process of finding a specific proof among many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant