-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify public API #12
Comments
For LazyLedger, we need to modify the erasure coded shares before they are committed to as row / col roots. Namely, we need to prefix the orig. data and the parity shares with their namespaces respectively. This is already possible using the public API by computing the row / column roots externally. But if we want to use the rsmt2d for this instead, we need to make it possible to transform the shares before they are committed to internally. See for example this test-code: https://github.com/lazyledger/lazyledger-core/blob/4256e2090ba71873ee4698353de7d6646db97907/p2p/ipld/plugin/plugin_test.go#L116-L129 |
Additional: #56 (comment) |
Another (potentially last?) point to address with the is how the library handles proofs: Currently, we extracted a tree interface with a @adlerjohn noticed:
I think the latter is the approach which we should aim for. This also means We should rename this test https://github.com/lazyledger/rsmt2d/blob/5a692bff96defabeaf8c928510c1894255e97761/datasquare_test.go#L115 We should also introduce a
Note that if we move handling Proofs to the caller of the library, we should explicitly state that in the documentation somewhere too. Also, I think we need a doc.go that goes a bit more into detail than the Readme. |
The current public facing API:
Should we:
Codec
interface and removing the existing Encode/Decode functions)related: #11
The text was updated successfully, but these errors were encountered: