Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor secret and passportData management #233

Open
0xturboblitz opened this issue Feb 26, 2025 · 0 comments
Open

Refactor secret and passportData management #233

0xturboblitz opened this issue Feb 26, 2025 · 0 comments

Comments

@0xturboblitz
Copy link
Contributor

Secret and passport data management is currently messy. There are many functions that have small variants, often have to handle JSON parsing and null/false returns.

Because this is so sensitive, right now we're trying never to change those functions to avoid breaking anything, but at one point we should refactor all of that on a branch and QA all the flows before merging.

Two useful facts:

  • Except in the backup/recovery flow, we always need both secret and passport data at the same time. It is thus simplest to have functions that return both.
  • We do not want to always require biometric authentication to access them, as they are often required for navigation. For instance, to know if the user is registered and if their passport is nullified onchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant