Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code SDK shows success animation when failure to verify #235

Open
0xturboblitz opened this issue Feb 26, 2025 · 1 comment
Open

QR code SDK shows success animation when failure to verify #235

0xturboblitz opened this issue Feb 26, 2025 · 1 comment

Comments

@0xturboblitz
Copy link
Contributor

Currently, the playground shows a green success animation when proof verification fails.

Looks like proof_generation_failed is never called, but instead proof_verified is called with a boolean passed by handleProofVerified.

@aaronmgdr
Copy link
Member

the ProofRequestStatus screen is solely based on the disclosureStatus from the proofProvider

sendVcAndDisclosePayload actually seems to internally call setDisclosureStatus whether this is a good idea or not is another question)

handleProofVerified seems to be unrelated.

there IS a flow however where it will go to a screen that shows success when it fails but that is when it takes users to the ConfirmBelongingScreen when they are not registered yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants