add name length validation for driver #98
Conversation
|
Seeking more advice and it's a hard restriction with names and am open to another number as well. @nb-ohad @travisn @BlaineEXE |
|
we create svc from the driver name which can be a maximum 63 chars, we also append |
Choosing an arbitary length which is 54 for the csi driver name and adding a validation to block CR creation if the name is having more chars. Signed-off-by: Madhu Rajanna <[email protected]>
|
/hold |
|
New discussed approach is to put a restriction on the CRD name to match the length restriction of the kubernetes csidriver object, not the minimal resource length limit and adjust all other dependent resources' names to consider the length and generate the name to ensure that we don't go beyond the kubernetes name restriction for all the resources like deployment/daemonset/service etc. |
|
54 chars seems like plenty to me. |
|
For me, this makes sense as well and not to think too much about it, if someone wants to have a different solution am going to close it and let others do it. |
|
Closing it as am not working on it anymore |
Describe what this PR does
Choosing an arbitrary length which is 56 for the csi driver name and adding a validation to block CR creation i the name has more chars.
Is there anything that requires special attention
Do you have any questions?
No
Is the change backward compatible?
Yes but only to an extent
Are there concerns around backward compatibility?
Yes, the migration not be possible for the existing driver if names are beyond 63 chars, or else we don't have a problem.
Related issues
Fixes: #44