diff --git a/packages/terra-framework-docs/CHANGELOG.md b/packages/terra-framework-docs/CHANGELOG.md index b7b9f9861b1..685e26c2c77 100644 --- a/packages/terra-framework-docs/CHANGELOG.md +++ b/packages/terra-framework-docs/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Changed + * Enabled `close` button in examples. + * ## 1.90.0 - (May 22, 2024) * Updated diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/compact-interactive-list/CellContent.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/compact-interactive-list/CellContent.test.jsx index 79cc0ae01ef..173903765ef 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/compact-interactive-list/CellContent.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/compact-interactive-list/CellContent.test.jsx @@ -74,6 +74,7 @@ const PopupWithInteractiveContent = () => { targetRef={getButtonNode} onRequestClose={handleRequestClose} contentHeight="auto" + isHeaderDisabled={false} > {/* eslint-disable-next-line react/forbid-dom-props */}
diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowHorizontalAttachmentsPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowHorizontalAttachmentsPopup.test.jsx index 4c4dc832551..64467c0fc9a 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowHorizontalAttachmentsPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowHorizontalAttachmentsPopup.test.jsx @@ -66,6 +66,7 @@ class AlignmentPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup arrow was horizontally attached.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowPopup.test.jsx index d06516ab081..fc9220a2c54 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowPopup.test.jsx @@ -46,6 +46,7 @@ class ArrowPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

this is popup content

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetLeftPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetLeftPopup.test.jsx index 17111f19dff..85d96328b3f 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetLeftPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetLeftPopup.test.jsx @@ -65,6 +65,7 @@ class OffsetPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup was adjusted because the target was smaller than the arrow position allowed.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetRightPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetRightPopup.test.jsx index 0583465ce50..9c0e5288115 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetRightPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowSmallTargetRightPopup.test.jsx @@ -65,6 +65,7 @@ class OffsetPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup was adjusted because the target was smaller than the arrow position allowed.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalAttachmentsPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalAttachmentsPopup.test.jsx index eb60abf7b5b..bd5d2702d80 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalAttachmentsPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalAttachmentsPopup.test.jsx @@ -66,6 +66,7 @@ class AlignmentPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup arrow has vertical attachment.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalLeftAdjustmentPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalLeftAdjustmentPopup.test.jsx index 67bc6fbbb89..58416b03356 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalLeftAdjustmentPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalLeftAdjustmentPopup.test.jsx @@ -65,6 +65,7 @@ class AlignmentPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup arrow has verital-left attachment, but was adjusted to be on the screen.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalRightAdjustmentPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalRightAdjustmentPopup.test.jsx index 5d2483ba565..d300e26909c 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalRightAdjustmentPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ArrowVerticalRightAdjustmentPopup.test.jsx @@ -65,6 +65,7 @@ class AlignmentPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup arrow has vertical-right attachment, but was adjusted to be on the screen.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightBoundedPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightBoundedPopup.test.jsx index c560adaca7f..25f3f7015c1 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightBoundedPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightBoundedPopup.test.jsx @@ -56,6 +56,7 @@ class PopupExample extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

This is popup content with a automatic height of 400px.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightPopup.test.jsx index 5fad007f7f8..a67be50dac8 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticHeightPopup.test.jsx @@ -45,6 +45,7 @@ class PopupExample extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

This is popup content with a automatic height of 400px.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthBoundedPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthBoundedPopup.test.jsx index 9e75f4be837..fda694d84a8 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthBoundedPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthBoundedPopup.test.jsx @@ -56,6 +56,7 @@ class PopupExample extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

This is popup content with a automatic width of 400px, but is bounded by the parent width of 200px.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthPopup.test.jsx index 3fc32f9a49c..764ba4742d1 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/AutomaticWidthPopup.test.jsx @@ -45,6 +45,7 @@ class PopupExample extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

This is popup content with a automatic width of 400px.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedHeightPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedHeightPopup.test.jsx index 652d0f57f99..38cf0fc51d6 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedHeightPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedHeightPopup.test.jsx @@ -56,6 +56,7 @@ class BoundedPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup is bounded by height.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedPopup.test.jsx index eb3c1529913..92dbdb7606b 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedPopup.test.jsx @@ -57,6 +57,7 @@ class BoundedPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup is bounded and presents a header.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedWidthPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedWidthPopup.test.jsx index b9300d7c583..50b2ba56b55 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedWidthPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/BoundedWidthPopup.test.jsx @@ -57,6 +57,7 @@ class BoundedPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup is bounded by width.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/DefaultPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/DefaultPopup.test.jsx index f3e3f4ad3fa..8b2797f8b1a 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/DefaultPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/DefaultPopup.test.jsx @@ -44,6 +44,7 @@ class DefaultPopup extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

this is popup content

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/DifferentAttachmentsPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/DifferentAttachmentsPopup.test.jsx index 615721f1562..63c5acca8e3 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/DifferentAttachmentsPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/DifferentAttachmentsPopup.test.jsx @@ -73,6 +73,7 @@ class AlignmentPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup arrow has vertical attachment.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/FocusTrapPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/FocusTrapPopup.test.jsx index 388f1ab163a..5cf48f06a71 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/FocusTrapPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/FocusTrapPopup.test.jsx @@ -45,6 +45,7 @@ class DefaultPopup extends React.Component { targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} contentHeight="auto" + isHeaderDisabled={false} >

this is popup content

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/PopupWithContentWidth.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/PopupWithContentWidth.test.jsx index b28cd931baf..5012d348dd8 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/PopupWithContentWidth.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/PopupWithContentWidth.test.jsx @@ -100,6 +100,7 @@ class PopupWithContentWidth extends Component { isOpen={open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

This is a popup with custom contentWidth and contentHeight

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ResizedContentPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ResizedContentPopup.test.jsx index 0abf14d3b0e..45fd9c3d32d 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/ResizedContentPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/ResizedContentPopup.test.jsx @@ -48,6 +48,7 @@ class PopupExample extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} > this.setState({ size: 'large' })} /> diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeInvalidPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeInvalidPopup.test.jsx index b8227eb4718..3c373b4097d 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeInvalidPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeInvalidPopup.test.jsx @@ -58,6 +58,7 @@ class DimensionPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup defaults its size.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeLargePopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeLargePopup.test.jsx index cf942a7a82c..18b94327411 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeLargePopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeLargePopup.test.jsx @@ -58,6 +58,7 @@ class DimensionPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup is 240h by 960w.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeMediumPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeMediumPopup.test.jsx index 4133bd0ece8..bd7a4522c1e 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeMediumPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeMediumPopup.test.jsx @@ -58,6 +58,7 @@ class DimensionPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup is 120h by 320w.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeSmallPopup.test.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeSmallPopup.test.jsx index 49e75d69e00..870514822ee 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeSmallPopup.test.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/SizeSmallPopup.test.jsx @@ -58,6 +58,7 @@ class DimensionPopup extends React.Component { isOpen={this.state.open} onRequestClose={this.handleRequestClose} targetRef={this.getButtonNode} + isHeaderDisabled={false} >

This popup is 40h by 160w.

diff --git a/packages/terra-framework-docs/src/terra-dev-site/test/popup/common/PopupModalContent.jsx b/packages/terra-framework-docs/src/terra-dev-site/test/popup/common/PopupModalContent.jsx index c224460fc61..4b054ef3194 100644 --- a/packages/terra-framework-docs/src/terra-dev-site/test/popup/common/PopupModalContent.jsx +++ b/packages/terra-framework-docs/src/terra-dev-site/test/popup/common/PopupModalContent.jsx @@ -40,6 +40,7 @@ class ModalContent extends React.Component { isOpen={this.state.open} onRequestClose={this.handlePopupRequestClose} targetRef={() => document.getElementById('popup-in-modal')} + isHeaderDisabled={false} >

This is popup content

diff --git a/packages/terra-pills/CHANGELOG.md b/packages/terra-pills/CHANGELOG.md index 836cfa803a7..6adb9d5db34 100644 --- a/packages/terra-pills/CHANGELOG.md +++ b/packages/terra-pills/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Added + * Enabled `close` button in Popup while opening from a pill. + ## 1.29.0 - (May 22, 2024) * Changed diff --git a/packages/terra-pills/src/subcomponents/_Pill.jsx b/packages/terra-pills/src/subcomponents/_Pill.jsx index 9171afb1534..d84df35bb6f 100644 --- a/packages/terra-pills/src/subcomponents/_Pill.jsx +++ b/packages/terra-pills/src/subcomponents/_Pill.jsx @@ -207,6 +207,7 @@ const Pill = (props) => { targetRef={getPillRef} onRequestClose={handleOnRequestClose} contentHeight="auto" + isHeaderDisabled={false} >
{labelCategory diff --git a/packages/terra-popup/CHANGELOG.md b/packages/terra-popup/CHANGELOG.md index cff766818ce..a0112bc0545 100644 --- a/packages/terra-popup/CHANGELOG.md +++ b/packages/terra-popup/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Changed + * Disabled `close` button in popup by default. + ## 6.85.0 - (May 22, 2024) * Changed diff --git a/packages/terra-popup/src/Popup.jsx b/packages/terra-popup/src/Popup.jsx index 06ca3224ffb..f14846d849d 100644 --- a/packages/terra-popup/src/Popup.jsx +++ b/packages/terra-popup/src/Popup.jsx @@ -122,7 +122,7 @@ const defaultProps = { contentWidth: '240', isArrowDisplayed: false, isContentFocusDisabled: false, - isHeaderDisabled: false, + isHeaderDisabled: true, isOpen: false, popupContentRole: 'dialog', isMenu: false, diff --git a/packages/terra-popup/src/_PopupContent.jsx b/packages/terra-popup/src/_PopupContent.jsx index 99aaf396d38..b285ba6e84d 100644 --- a/packages/terra-popup/src/_PopupContent.jsx +++ b/packages/terra-popup/src/_PopupContent.jsx @@ -93,7 +93,7 @@ const defaultProps = { contentHeightMax: -1, contentWidthMax: -1, isFocusedDisabled: false, - isHeaderDisabled: false, + isHeaderDisabled: true, isHeightAutomatic: false, isWidthAutomatic: false, popupContentRole: 'dialog', diff --git a/packages/terra-popup/tests/jest/PopupContent.test.jsx b/packages/terra-popup/tests/jest/PopupContent.test.jsx index c1d6de55673..199079fef30 100644 --- a/packages/terra-popup/tests/jest/PopupContent.test.jsx +++ b/packages/terra-popup/tests/jest/PopupContent.test.jsx @@ -9,6 +9,7 @@ describe('PopupContent', () => { contentWidth: 640, onRequestClose: jest.fn(), onResize: jest.fn(), + isHeaderDisabled: false, }; const children =
children node(s)
; diff --git a/packages/terra-popup/tests/jest/PopupDefaultExample.jsx b/packages/terra-popup/tests/jest/PopupDefaultExample.jsx index cbbdd1fb96a..bce8fbcd212 100644 --- a/packages/terra-popup/tests/jest/PopupDefaultExample.jsx +++ b/packages/terra-popup/tests/jest/PopupDefaultExample.jsx @@ -31,6 +31,7 @@ class PopupDefaultExample extends React.Component { isOpen={this.state.open} targetRef={this.getButtonNode} onRequestClose={this.handleRequestClose} + isHeaderDisabled={false} >

this is popup content