Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manually closing and lmp instance #36

Merged
merged 6 commits into from
Nov 4, 2023
Merged

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Nov 2, 2023

No description provided.

src/LAMMPS.jl Outdated Show resolved Hide resolved
src/LAMMPS.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #36 (5d58126) into main (126d971) will increase coverage by 0.51%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   35.48%   36.00%   +0.51%     
==========================================
  Files           2        2              
  Lines         372      375       +3     
==========================================
+ Hits          132      135       +3     
  Misses        240      240              
Files Coverage Δ
src/LAMMPS.jl 53.76% <100.00%> (+0.70%) ⬆️

src/LAMMPS.jl Outdated Show resolved Hide resolved
@vchuravy vchuravy merged commit e67bbc4 into main Nov 4, 2023
9 of 12 checks passed
@vchuravy vchuravy deleted the vc/manual_close branch November 4, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants