Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down institution data retrieval #111

Closed
lchen-2101 opened this issue Mar 11, 2024 · 2 comments · Fixed by #120
Closed

Lock down institution data retrieval #111

lchen-2101 opened this issue Mar 11, 2024 · 2 comments · Fixed by #120
Assignees
Labels
backend backend development

Comments

@lchen-2101
Copy link
Collaborator

Have institution retrieval be tied to user email domain and / or associated lei

@lchen-2101 lchen-2101 added the backend backend development label Mar 11, 2024
@jcadam14
Copy link
Contributor

jcadam14 commented Mar 14, 2024

I created a story in filing-api cfpb/sbl-filing-api#105 where I comment it might be good to put in the commons repo a router that does the check for lei like I added to filing, so all our apis can reuse that router if needed. So might be something to discuss/think about for this, too.

@lchen-2101
Copy link
Collaborator Author

lchen-2101 commented Mar 14, 2024

Yeap, some functionalities are shared between the two; the path-based ones will pretty much be the same. The part that doesn't quite fit both is the search / query-param based; also there's an "admin" type user that can do everything here that I'm thinking of preserving. Exploring using decorator instead of dependencies at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants