Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_voluntary field to be nullable #474

Closed
jcadam14 opened this issue Oct 28, 2024 · 0 comments · Fixed by #475
Closed

Update is_voluntary field to be nullable #474

jcadam14 opened this issue Oct 28, 2024 · 0 comments · Fixed by #475
Assignees
@jcadam14

Comments

@jcadam14
Copy link
Contributor

Change the is_voluntary field to be optional/nullable in the database, DAO, DTO.

Add a check during the /sign endpoint to verify the filing.is_voluntary is not null, much like we do with contact_info.
@jcadam14 jcadam14 self-assigned this Oct 28, 2024
@jcadam14 jcadam14 linked a pull request Oct 28, 2024 that will close this issue
474 update is voluntary field to be nullable #475
Merged
@jcadam14 jcadam14 mentioned this issue Oct 28, 2024
Merged
lchen-2101 pushed a commit that referenced this issue Oct 29, 2024
@jcadam14
474 update is voluntary field to be nullable (#475)
71d24a3 
Closes #474 

Need to update either this or #473 due to each PR have an alembic
script, so will need to make whichever PR is reviewed/approved last
alembic based on the first PR merged in.
@jcadam14 jcadam14 mentioned this issue Oct 30, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

474 update is voluntary field to be nullable cfpb/sbl-filing-api
1 participant
@jcadam14