Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sidecar): review default options for CLI flags #295

Closed
thedevbirb opened this issue Oct 16, 2024 · 0 comments · Fixed by #296
Closed

chore(sidecar): review default options for CLI flags #295

thedevbirb opened this issue Oct 16, 2024 · 0 comments · Fixed by #296
Labels
C: bolt-sidecar Component: bolt-sidecar D-good-first-issue Difficulty: a great choice to get started! T: chore Type: Chore

Comments

@thedevbirb
Copy link
Contributor

thedevbirb commented Oct 16, 2024

There are many configuration options in the sidecar that have a default (for testing reasons) but they shouldn't have one, and we should make sure the users manually sets them. Some examples include:

  • fee recipient
  • builder private key
  • jwt hex
  • etc..

This requires also modifying our fork of the Ethereum package in order to provide the correct values and run the devnet successfully.

A PR should be built on top of #296 which already touches some of the CLI flag descriptions etc.

@thedevbirb thedevbirb added C: bolt-sidecar Component: bolt-sidecar D-good-first-issue Difficulty: a great choice to get started! T: chore Type: Chore labels Oct 16, 2024
@thedevbirb thedevbirb added this to the v0.3: Holesky 1 milestone Oct 16, 2024
@thedevbirb thedevbirb mentioned this issue Oct 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-sidecar Component: bolt-sidecar D-good-first-issue Difficulty: a great choice to get started! T: chore Type: Chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants