Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove L1 related fields from L2BlockHeader #1791

Open
Tracked by #1784
eyusufatik opened this issue Jan 31, 2025 · 3 comments
Open
Tracked by #1784

Remove L1 related fields from L2BlockHeader #1791

eyusufatik opened this issue Jan 31, 2025 · 3 comments
Assignees
Milestone

Comments

@eyusufatik
Copy link
Member

eyusufatik commented Jan 31, 2025

May be done before or after #1766, does not matter.

The l1_hash and l1_height should be removed from soft confirmation and signed soft confirmation structures, because #1788 will now handle system transactions inside normal txs field of the soft confirmation.

@varun-doshi
Copy link

Please correct me if im wrong but i dont see l1_hash and l1_height in this structure:

#[derive(PartialEq, Eq, BorshDeserialize, BorshSerialize, Serialize, Deserialize)]
pub struct SignedSoftConfirmation<'txs, Tx: Clone> {
    l2_height: u64,
    hash: [u8; 32],
    prev_hash: [u8; 32],
    da_slot_height: u64,
    da_slot_hash: [u8; 32],
    da_slot_txs_commitment: [u8; 32],
    l1_fee_rate: u128,
    blobs: Cow<'txs, [Vec<u8>]>,
    txs: Cow<'txs, [Tx]>,
    signature: Vec<u8>,
    deposit_data: Vec<Vec<u8>>,
    pub_key: Vec<u8>,
    timestamp: u64,
}

@varun-doshi
Copy link

varun-doshi commented Feb 3, 2025

Removing the mentioned fields in the issue would mean that this function is not possible anymore. Would like to confirm if thats the intended direction?this is one of the functions that will have to be removed

@eyusufatik
Copy link
Member Author

Removing the mentioned fields in the issue would mean that this function is not possible anymore. Would like to confirm if thats the intended direction?this is one of the functions that will have to be removed

the SoftConfirmationRuleEnforcer can read the last L1 block hash from EVM and keep track through the value read

@jfldde jfldde self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants