From d33a58269317bc2fdc2c279e5c30f7f56fdba1e0 Mon Sep 17 00:00:00 2001 From: anubra266 Date: Sun, 6 Oct 2024 01:36:45 -0500 Subject: [PATCH] fix: array syntax in `no-dynamic-styling` --- .changeset/happy-geckos-fold.md | 5 +++++ plugin/src/rules/no-dynamic-styling.ts | 11 ++++------- 2 files changed, 9 insertions(+), 7 deletions(-) create mode 100644 .changeset/happy-geckos-fold.md diff --git a/.changeset/happy-geckos-fold.md b/.changeset/happy-geckos-fold.md new file mode 100644 index 0000000..cb969dc --- /dev/null +++ b/.changeset/happy-geckos-fold.md @@ -0,0 +1,5 @@ +--- +'@pandacss/eslint-plugin': patch +--- + +Fix array syntax in `no-dynamic-styling` diff --git a/plugin/src/rules/no-dynamic-styling.ts b/plugin/src/rules/no-dynamic-styling.ts index 59e6e89..6bff5f3 100644 --- a/plugin/src/rules/no-dynamic-styling.ts +++ b/plugin/src/rules/no-dynamic-styling.ts @@ -45,13 +45,10 @@ const rule: Rule = createRule({ // Don't warn for objects. Those are conditions if (isObjectExpression(node.value.expression)) return - if (isArrayExpression(node.value.expression)) { - return checkElements(node.value.expression, context) - } - if (!isPandaProp(node, context)) return + if (isArrayExpression(node.value.expression)) { - return checkElements(node.value.expression, context) + return checkArrayElements(node.value.expression, context) } context.report({ @@ -83,7 +80,7 @@ const rule: Rule = createRule({ if (!isPandaAttribute(node, context)) return if (isArrayExpression(node.value)) { - return checkElements(node.value, context) + return checkArrayElements(node.value, context) } context.report({ @@ -95,7 +92,7 @@ const rule: Rule = createRule({ }, }) -function checkElements(array: TSESTree.ArrayExpression, context: Parameters<(typeof rule)['create']>[0]) { +function checkArrayElements(array: TSESTree.ArrayExpression, context: Parameters<(typeof rule)['create']>[0]) { array.elements.forEach((node) => { if (!node) return if (isLiteral(node)) return