Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfish power control dev scripts allow a failure to go undetected #85

Closed
garlick opened this issue Jan 25, 2024 · 2 comments
Closed

redfish power control dev scripts allow a failure to go undetected #85

garlick opened this issue Jan 25, 2024 · 2 comments
Assignees

Comments

@garlick
Copy link
Member

garlick commented Jan 25, 2024

Problem: when a power control command fails, the redfishpower expect scripts just expect the prompt so they succeed, and the failure is not reflected in the powerman command exit code.

@garlick
Copy link
Member Author

garlick commented Jan 26, 2024

Since copies of the redfishpower dev scripts with this error have proliferated, one fix for this that would not require those scripts to be tracked down and changed would be to make the redfishpower internal timeout infinite by default so it is always the powerman timeout which catches the error not the redfishpower one.

Edit: note that the internal timeout can now be changed via the dev script as of #72

@chu11
Copy link
Member

chu11 commented Apr 4, 2024

going to close this, as the more general #171 will supplant this

@chu11 chu11 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants