Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graal backends structure improvement proposal #104

Closed
leonvisscher opened this issue Jan 18, 2022 · 2 comments
Closed

Graal backends structure improvement proposal #104

leonvisscher opened this issue Jan 18, 2022 · 2 comments

Comments

@leonvisscher
Copy link

Hi @zhquan and @vchrombie!

As part of the Grimoirelab MSR hackathon our team has been working on making some refactoring and maintenance contributions for the Graal project. Based on our experience of using Graal and exploring the code we identified some refactoring opportunities. Besides that we looked at the existing issues in this repository, and found issue Issue #89 which discusses the current backend structure/approach of Graal.

Yesterday we had a meeting with @valeriocos to discuss our proposal and got some good feedback. Valerio suggested us to contact you to discuss this further. We are very interested in getting your thoughts on this proposal and would like to get in touch.

We have worked out a POC for improving this structure (https://github.com/wmeijer221/grimoirelab-graal/tree/refactor). To give an impression, below are two figures that show the current and proposed structure.

Current structure

Screenshot from 2022-01-18 15-59-28

Proposed structure

Screenshot from 2022-01-18 15-59-38

@vchrombie
Copy link
Member

Hi @leonvisscher, thanks for your interest in the GrimoireLab.

Your approach looks much simpler which was the goal of issue #89 if I understand correctly. I didn't get time to look more into the code to understand the approach. I will surely look into it this weekend.

Also, I'm interested to hear comments from @sduenas and @jgbarah, and what they think about it?

This was referenced Jan 21, 2022
@leonvisscher
Copy link
Author

Thanks for you reaction @vchrombie!

We have opened a pull request where we've implemented this proposal for only the CoLic backend to keep the changes comprehensible. Would you be able to look at the PR this week? We would like to gather and process feedback before the hacakthon submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants