feat: quality of life updates to Slurm snap #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull `mungectl` from https://github.com/charmed-hpc/mungectl rather than use vendored version. `mungectl` was moved out into its own repository. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
These two sets of configure hooks had to be removed as they were buggy and had limited interaction with their respective config files. For example, through snap config, you could only have one down nodes entry at a time. The configure hooks also did not support the Slurm hostname specification which is common syntax in Slurm. Now users are encouraged to edit the file directly under $SNAP_COMMON, and the snap config hook can only be used to configure Slurm service definitions, not modify config files like slurm.conf, slurmdbd.conf, gres.conf, etc. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Bring CONTRIBUTING.md up to date. Originally mentioned using tox which was not the correct entrypoint. Signed-off-by: Jason C. Nucciarone <[email protected]>
…istently out of date Reduce maintenance overhead of requiring someone to go through our repos and update comments within bespoke workflow files. Signed-off-by: Jason C. Nucciarone <[email protected]>
Refresh brings README forward to be like other Charmed HPC-related repositories. Also removes mention of old configuration hooks that edited the slurm.conf and slurmdbd.conf files. Signed-off-by: Jason C. Nucciarone <[email protected]>
Ruff changed the format of its configuration within pyproject.toml. This commit updates pyproject.toml so that ruff does not throw off warnings when running just recipes. Signed-off-by: Jason C. Nucciarone <[email protected]>
|
Secrets should be good. Might need to refresh the Launchpad token, but that one is more of a pain to refresh so we'll see if it's stale after we merge this PR. |
2 tasks
jedel1043
approved these changes
Jan 14, 2025
jedel1043
requested changes
Jan 14, 2025
Lol all good. I was gonna address your comment before merging anyway 🤣 |
Update .editorconfig to remove old reference to Make and Go-related files, and define formatting rules for justfiles. `just` has a built-in formatter that can be run using the command `just --fmt --unstable`. Signed-off-by: Jason C. Nucciarone <[email protected]>
The `snap` recipe now depends on the `clean` recipe to ensure the instance is fresh before building the snap. `integration` now depends on `snap`. Build instance must be refreshed each time the snap is built before of bug: canonical/craft-parts#675 Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
nuccitheboss/qol-updates
branch
2 times, most recently
from
52a268c to
88f08de
Compare
Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
nuccitheboss/qol-updates
branch
from
88f08de to
17faa73
Compare
|
@jedel1043 R4R |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refreshes the Slurm snap with necessary quality of life updates. Changes include:
makewithjust. Less.PHONY: ...the better...mungectl. It wasn't as update to date with the upstreammungectlrepository.DownNodesentry and did not support Slurm hostname specification.Related issues